@nolash the puritan approach of trying to scope the usage of components to be mainly from the p2p package is biting me in the axx. the swarm simulations package stitches additional abstractions over the p2p ones. notably:
https://github.com/ethersphere/go-ethereum/blob/9e9fc87e70accf2b81be8772ab2ab0c914e95666/swarm/network/simulation/simulation.go#L66

https://github.com/ethersphere/go-ethereum/blob/9e9fc87e70accf2b81be8772ab2ab0c914e95666/p2p/simulations/adapters/types.go#L231

right now i'm using the swarm simulations package just to wait for the network health (basically just creating an empty simulation and injecting the network object into it, then calling the health function).

I think that this really isn't necessary to have this method with a simulation as a receiver, but rather a function that just takes a Network as an argument.

@zelig,
I can understand your concerns with this PR.
My view on this is that maybe this is not really obviously necessary, but I personally don't like the fact that snapshot generation is being handled inside an e2e test.
Therefore, I think that splitting this to a separate binary is indeed the way to go. Also, I have to say that working through the swarm simulations and p2p simulations helps a lot to see where we need to clean up and where are our current weaknesses in the way we use the simulations framework. Speaking of duplicate code, there's a lot of it there and there's still room to make it cleaner and better so we can really finish the work on this piece of the puzzle. Speaking for myself, I think we still can't fully reason about the simulations FW, and hopefully cleaning stuff up will help resolve the flakiness that we have every now and then.

That being said, there's certain boilerplate code that is indeed replicated and unnecessary, and maybe we should think about having just one toolbox binary that includes, for example, smoke tests, snapshot generation, snapshot verification and any other need that might arise further down the road for that matter.

linter fails https://travis-ci.org/ethersphere/go-ethereum/jobs/477430239#L513 @janos

@nolash @zelig @janos i removed the verification command from the binary and the snapshot json. verification will be relied upon testing.